Skip to content

stratisd.spec: Change dracut order number from 90 to 50#558

Merged
mulkieran merged 1 commit intostratis-storage:masterfrom
mulkieran:dracut-module-renumber
Sep 12, 2025
Merged

stratisd.spec: Change dracut order number from 90 to 50#558
mulkieran merged 1 commit intostratis-storage:masterfrom
mulkieran:dracut-module-renumber

Conversation

@mulkieran
Copy link
Copy Markdown
Member

@mulkieran mulkieran commented Sep 12, 2025 •
edited by coderabbitai bot
Loading

Related stratis-storage/stratisd#3908

Summary by CodeRabbit

  • Chores
    • Adjusted initramfs integration by moving Stratis and Stratis-Clevis dracut modules to an earlier load directory (modules.d/50), covering setup scripts, udev rules, and the minimal service.
    • Systemd generators for Stratis and Stratis-Clevis remain unchanged.

@mulkieran
stratisd.spec: Change dracut order number from 90 to 50
85842e0 
Signed-off-by: mulhern <amulhern@redhat.com>
@mulkieran mulkieran self-assigned this Sep 12, 2025
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Sep 12, 2025 •
edited
Loading

Walkthrough

Adjusted dracut module paths in the spec file’s %files dracut block from modules.d/90stratis-* to modules.d/50stratis-* for six entries. Systemd generator entries were unchanged. No other sections were modified.

Changes

Cohort / File(s) Summary of Changes
Dracut module path updates
mockbuild_test/stratisd.spec		 Updated six %files entries to move dracut modules from %{dracutdir}/modules.d/90stratis-* to %{dracutdir}/modules.d/50stratis-*; kept system generator entries unchanged.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Pre-merge checks (3 passed)

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The title "stratisd.spec: Change dracut order number from 90 to 50" succinctly and accurately conveys the primary change in the changeset — renumbering dracut module entries in stratisd.spec from 90 to 50. It names the affected file and the core modification, is specific and readable, and would be clear to a teammate scanning history.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.

Poem

I hop through specs with tidy cheer,
From ninety down to fifty here.
Dracut lanes now neatly set,
Generators steady yet.
With paws of care I nudge the tree—
A lighter build for buns like me. 🐇✨

Tip

👮 Agentic pre-merge checks are now available in preview!

Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.

  • Built-in checks – Quickly apply ready-made checks to enforce title conventions, require pull request descriptions that follow templates, validate linked issues for compliance, and more.
  • Custom agentic checks – Define your own rules using CodeRabbit’s advanced agentic capabilities to enforce organization-specific policies and workflows. For example, you can instruct CodeRabbit’s agent to verify that API documentation is updated whenever API schema files are modified in a PR. Note: Upto 5 custom checks are currently allowed during the preview period. Pricing for this feature will be announced in a few weeks.

Please see the documentation for more information.

Example:

reviews:
  pre_merge_checks:
    custom_checks:
      - name: "Undocumented Breaking Changes"
        mode: "warning"
        instructions: |
          Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).

Please share your feedback with us on this Discord post.

✨ Finishing touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@mulkieran mulkieran moved this to In Progress in 2025September Sep 12, 2025
@mulkieran mulkieran marked this pull request as ready for review September 12, 2025 14:57
@mulkieran mulkieran moved this from In Progress to In Review in 2025September Sep 12, 2025
coderabbitai[bot]
coderabbitai bot reviewed Sep 12, 2025
View reviewed changes
Copy link
Copy Markdown

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
mockbuild_test/stratisd.spec (1)

154-159: Please verify upstream install paths and ordering assumptions before merging.

  • Ensure the build/install actually places these files under modules.d/50{stratis,stratis-clevis}; otherwise the build will fail at %files with “File not found” or “Installed (but unpackaged) file(s) found.”
  • Confirm module-setup.sh depends() in both modules still encode any prerequisites now that execution will occur earlier (e.g., systemd, cryptsetup/clevis, lvm/dm). If order is critical for boot, plan for an initramfs rebuild note in release docs.

Optional improvement: explicitly own the module directories to avoid ownership gaps on cleanup.

 %files dracut
 %license LICENSE
+%dir %{dracutdir}/modules.d/50stratis-clevis
+%dir %{dracutdir}/modules.d/50stratis
 %{dracutdir}/modules.d/50stratis-clevis/module-setup.sh
 %{dracutdir}/modules.d/50stratis-clevis/stratis-clevis-rootfs-setup
 %{dracutdir}/modules.d/50stratis/61-stratisd.rules
 %{dracutdir}/modules.d/50stratis/module-setup.sh
 %{dracutdir}/modules.d/50stratis/stratis-rootfs-setup
 %{dracutdir}/modules.d/50stratis/stratisd-min.service
📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 57a1c87 and 85842e0.

📒 Files selected for processing (1)
  • mockbuild_test/stratisd.spec (1 hunks)
🔇 Additional comments (1)
mockbuild_test/stratisd.spec (1)

154-159: LGTM: paths updated to 50stratis/50stratis-clevis look consistent with the renumbering goal.
The six entries correctly mirror the intended move from 90 → 50 within dracut’s modules.d hierarchy.

@mulkieran mulkieran mentioned this pull request Sep 12, 2025
Merged
@mulkieran mulkieran merged commit fdbc2a3 into stratis-storage:master Sep 12, 2025
6 checks passed
@github-project-automation github-project-automation bot moved this from In Review to Done in 2025September Sep 12, 2025
@mulkieran mulkieran deleted the dracut-module-renumber branch September 12, 2025 15:45
@mulkieran mulkieran moved this from Done to Done(2) in 2025September Sep 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

Assignees

@mulkieran mulkieran

Labels

None yet

Projects

No open projects
2025September
Status: Done(2)

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@mulkieran